-
Notifications
You must be signed in to change notification settings - Fork 927
Remove -alpha artifacts from runtime classpath of stable components #6944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6944 +/- ##
============================================
- Coverage 89.99% 89.94% -0.06%
- Complexity 6596 6634 +38
============================================
Files 729 745 +16
Lines 19858 20010 +152
Branches 1955 1962 +7
============================================
+ Hits 17871 17997 +126
- Misses 1389 1417 +28
+ Partials 598 596 -2 ☔ View full report in Codecov by Sentry. |
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkMeter.java
Outdated
Show resolved
Hide resolved
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SdkTracer.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| void incubatingLogSdk() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why, but these new graal nativeTest woked without any additional reflect-config.json entries, despite new reflective access in the SDK via Class.forName. 🤔
trask
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
.../src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/ExtendedSdkLongGauge.java
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/ExtendedSdkLongHistogram.java
Show resolved
Hide resolved
| import static io.opentelemetry.sdk.trace.internal.TracerConfig.defaultConfig; | ||
| import static io.opentelemetry.sdk.trace.internal.TracerConfig.disabled; | ||
| import static io.opentelemetry.sdk.trace.internal.TracerConfig.enabled; | ||
| import static org.assertj.core.api.Assertions.assertThat; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import static org.assertj.core.api.Assertions.assertThat; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the build pass despite this unused import? 🤔
Related to #6970.
Remove
-alphaartifacts (especiallyopentelemetry-api-incubator) from the runtime classpath of stable components.Approach is:
implementationtocompileOnlydependencies-alphaartifact is present on classpath (i.e. provided by the user) and toggle behavior based on whether it is or isnt-alphaartifacts are not provided by user, make sure main test suite runs without-alphaartifacts.-alphaartifacts are present, introduce new test suite including the-alphaartifacts, and test the impacted behaviorThis is related to a possible adjustment of our versioning guidelines. If we went in this direction, a user adding only stable dependencies could always run
./gradlew dependenciesand will not see any-alphaartifacts on the runtime classpath.